arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
102 stars 14 forks source link

[BUG] [TWW Beta] Enabling Warband Bank Causes Error Message #1907

Open Calesta opened 6 days ago

Calesta commented 6 days ago

What version number you are using? v31033.Alpha.5

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta TWW Beta

What language is the game client set to? English

Describe the bug A clear and concise description of what the bug is. I finally enabled the Warband bank functionality on the Beta client to test it out. It doesn't look like it's yet been integrated into the ArkInventory functions UI so I just disabled it, deposited what I wanted to remove from my bags and enabled it again. Since then, I see the following error message every now and then but I'm not sure what's triggering it.

To Reproduce Steps to reproduce the behaviour, if possible:

Screenshots If applicable, add screenshots to help explain your problem.

Error - After Warband Bank Enabled

Additional context Add any other context about the problem here.

Again, I realize this is an Alpha build and there's probably a lot still being reviewed. I'm simply raising this issue for awareness to help with troubleshooting. Hopeful that it can be resolved for launch!

arkayenro commented 6 days ago

bag ids 13 thru 17 are the warbank slots.

im trying to work how i can integrate the account level bank data with character level bank data for those new slots. i can get it to store into the character data but thats going to screw up item counts.

DT-DIY-Tech commented 4 days ago

How do you save guildbank data, wouldn't it be possible to use the same data structure for warband banks?

fraerie commented 3 days ago

even if it can't include the inventory counts - as it stands we can't even view the warband bank tab if arkinventory is enabled

arkayenro commented 1 day ago

even if it can't include the inventory counts - as it stands we can't even view the warband bank tab if arkinventory is enabled

so disable it. dont expect things to just work in a beta

How do you save guildbank data, wouldn't it be possible to use the same data structure for warband banks?

vault data is stored as its own player, the warband bank is account wide so its closer to heirlooms, the problem was that a location belonged only to a specific player, or guild, or account, and the code could only access and display it that way. the warbank is account wide but is accessed via the bank interface, its part of the bank, and the code couldnt handle that.

if i made a new window for it then both the bank window and the warbank window would close when you closed the other one because theyre both linked the bank access.

plus whatever i do still needs to work with the other game clients.

i've rewritten most of it now so it should be viable in alpha 6 once i get that uploaded either today or tomorrow.

Calesta commented 5 hours ago

The latest alpha seems to have fixed the error message and it appears you've added the War Bank functionality to that of the bank view which makes sense to me. Thanks for all the fixes and new functionality!

I added some items to the warband bank and everything seems just fine. When I tried to 'restack' the bank, though, I got this error message.

image