[BUG] Restack bugs out in Classic Era on Arrows

[Gogo1951]

What version number you are using?

Latest from Curse

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta

Classic Era

What language is the game client set to?

Engrish

Describe the bug A clear and concise description of what the bug is.

When I hit "restack" on my hunter... it gets stuck in a loop trying to stack the bag.

Also, when I hit restack it doesn't try and put arrows in the quiver if they are in another bag. (Happens when you buy a new quiver.)

To Reproduce Steps to reproduce the behaviour, if possible:

Get on a hunter, hit "restack", kaboom!

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Love that you're still building this add-on! (=

[Gogo1951]

It happens when my bags aren't full too! Ha.

And it'll stay like this until I /reload.

[arkayenro]

the code should work but im not really sure. quivers arent profession bags but they will look like one to the restack code as it doesnt specifically know about quivers.

it will never fill them up though as arrows are projectiles, not crafting materials or reagents.

i dont play classic so i'd have to level one up enough.

for the moment i would suggest right clicking on the quiver and selecting restack > disable so it doesnt get stuck.

[Gogo1951]

Thanks!

Hypothetically, if you wanted to test, it wouldn't take leveling a new alt... all you'd have to do is make a hunter in Classic Era. They start with a Quiver and Arrows. (=

[Gogo1951]

I thought this was fixed, but it's not. Not trying to be a pain, just reporting what I'm seeing. Hitting restack just puts you in a loop with arrows in your quiver. You end up having to /reload to fix it.

[Wintercypher]

I can confirm that in previous versions this worked without an issue.

The scenario is that you have Arrows outside of the quiver. Previously the addon would always fill up the quiver by restacking. Now it errors.

[arkayenro]

ok, must be something funky with the split. not sure how but ill take a look and see if i can work it out

[arkayenro]

im not getting an error? 6 slot quiver, all slots full but 3 partial stacks, two full stacks outside. its restacking correctly and no error?

[arkayenro]

ooh, its inconsistent - doesnt always generate the error but i never loop

[arkayenro]

im still not really sure why it was happening but on the presumption that it didnt like splitting a full stack for whatever reason i've recoded it to not do that and it seems to be fine so far

[Ianni]

in cata classic, the restack aglorithm is also stuck on conjured mana cake (and some other things i dont remember)

[Wintercypher]

To reproduce, You must have the following

• Quiver (assuming ammo pouch does it too)
• Fill the quiver with ammo
• Use up some of the ammo in the quiver so that at least one is not at 200
• With all Quiver slots filled, buy another ammo stack
• Now restack

Expected results is that the ammo stack outside of the quiver will split and fill the partial in the quiver

Actual, Split loop