search

arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
110 stars 14 forks source link

Items not stacking when right clicking Items into Warband bank #2012

Open Bakermoose opened 2 months ago

Bakermoose commented 2 months ago

What version number you are using? 3.11.01 Alpha 5

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta Retail

What language is the game client set to? English

Describe the bug A clear and concise description of what the bug is. When I right click an item in my bags with the warband bank open, it goes into that bank but it will not stack with something already in there. Regular bank and guild bank work.

To Reproduce Get item. Split. Put 1 in warband bank. Right click.

Additional context Add any other context about the problem here. was using the non alpha build but didn't work with that either. Disabling Ark will allow it to work.

SgtMorrigahnGaming commented 2 months ago

I have the same issue. Also, when I click "cleanup" button in the warband, I get an voice error "This item is locked" or something like that.

arkayenro commented 2 months ago

my right click function does not add to existing stacks, and i havent gotten around to looking for existing stacks to put stuff into, just an empty slot.

cleanup is blizzard code - i cant fix any issues there, but i think thats a common issue with it but it doesnt seem to actually cause a problem

sraybell commented 2 months ago

The cleanup function through ArkInventory results in this error, but the invocation of the clean up function through the base UI doesn't result in the message, and it actually seems to sort properly.

There appears to be more going on here as I'm seeing this behavior as well and it does appear to only partially work, or not at all through ArkInventory invocation. Maybe the method call/api changed and there's additional arguments, or that's a new specific warbank call.

I'll see about recording a video and replying with a youtube link sometime tomorrow.

Bakermoose commented 2 months ago

From what i see the other two bag addons allow right click stacking in the warband bank, bagnon and baginator.

arkayenro commented 2 months ago

and i can simply set it back to the default right click action and let it all end up in tab 1 of the warbank but i didnt think people would want that

until i can add a bunch of extra code to look for existing stacks and handle partial stacks where it wont all fit, etc, etc, its going to remain like this.

Bakermoose commented 2 months ago

would it be worth to see what those other mods are doing? Bagnon I know works for sure

SgtMorrigahnGaming commented 2 months ago

I haven't seen an update to the mod since this thread was created, but now it all works. Setting up the bags through rightclick ( in the warband ) and choosing the correct tab you want does indeed now sort and stack and restack. I'm not a coder, but if Arkayenro didn't push an update this has been an Blizzard thing. Cause I'm cleaning and stacking and restacking on all my chars. Only thing is that it flashes red on those items that can not go into warband, I don't know why it's trying to move those, but just wait 5 seconds, and all that can be is moved and sorted.