search

arkency / find-open-source-mentor

A platform to connect junior developers with open source projects
35 stars 11 forks source link

Create an empty Rails app to start showing welcome message #4

Closed oxanayoxana closed 5 years ago

oxanayoxana commented 5 years ago
andrzejkrzywda commented 5 years ago

Hey @oxanayoxana - thanks for the first PR here ❤️

The goal of this issue was to start the whole initiative with an empty Rails app. Your first commit does exactly that.

The second commit includes a number of new gems, each of them is probably a good addition, but let's make small steps and add them when we feel they're needed. The reasoning here is that not all gems may be familiar to the potential contributors + not all gems I (as a mentor) am experienced with enough to help people get going.

The second commit also involves welcome#index which I'm happy to accept too.

I'd be quite happy to accept/merge this PR as it is now - but if you'd like to remove the gem-addition changes, it would make me even happier 😄

oxanayoxana commented 5 years ago

@andrzejkrzywda, thanks for taking time and explaining! Took those gems away)

andrzejkrzywda commented 5 years ago

Looks good, merging, thanks! 👍