arkenfox / user.js

Firefox privacy, security and anti-tracking: a comprehensive user.js template for configuration and hardening
MIT License
10.16k stars 516 forks source link

Slack login with Google breaks #1073

Closed rjshrjndrn closed 3 years ago

rjshrjndrn commented 3 years ago

Not able to sign in because popup is getting closed. I tried editing

/* 2210: block popup windows
 * [SETTING] Privacy & Security>Permissions>Block pop-up windows ***/
user_pref("dom.disable_open_during_load", false);

but in vain. Any direction will be appreciated. Thanks image

rjshrjndrn commented 3 years ago

@Thorin-Oakenpants By default, it was true, and I changed it to false. But the same effect.

rjshrjndrn commented 3 years ago

wait a second... if I go to slack to sign in .. and I click continue with google, it opens a new tab ... what is meant to happen next?

Yes it opens a new google signin popup, where we will enter our creds and authenticate.

where is it breaking down? I mean you then enter your email and then password and then what? What should happen? What does happen?

After authentication, that popup closes, and then from the original tab(the slack one) it'll just rediect to slack app.

Also did this just start happening, or is have you only just started using the user.js and/or slack+google-signin?

I tried the same flow with brave, and it's working fine. Yeah I just started to use user.js

rjshrjndrn commented 3 years ago

will try that out. Thanks :)

earthlng commented 3 years ago

hi

try resetting browser.link.open_newwindow.restriction

rjshrjndrn commented 3 years ago

image

@earthlng I commented out the above string in config, and still got same issue.

This is my override.js

// USER CONFIGS //

user_pref("dom.allow_cut_copy", true); // 2400
/* google meet */
user_pref("media.getusermedia.screensharing.enabled", true); // 2022
user_pref("media.peerconnection.enabled", true); // 2001
user_pref("media.peerconnection.ice.no_host", false); // 2001
user_pref("dom.webaudio.enabled", true); // 2510
user_pref("media.autoplay.blocking_policy", 0); // 2031

// URL search
user_pref("keyword.enabled", true); //0801
user_pref("browser.search.suggest.enabled", true); //0807
user_pref("browser.urlbar.suggest.searches", true); //0807
user_pref("privacy.clearOnShutdown.history", false); // 2803

// SSO login
// user_pref("dom.popup_allowed_events", "change click dblclick auxclick mouseup pointerup notificationclick reset submit touchend contextmenu"); //2212

cc @Thorin-Oakenpants

rjshrjndrn commented 3 years ago

I always, change the config and restart firefox. I Think that's enough right ?

crssi commented 3 years ago

I always, change the config

Whatever is in user.js file will get set when you start Firefox. So, If you do comment out in user.js, then you need to reset also the same in about:config.

rjshrjndrn commented 3 years ago

oh okay. Lemme try that @crssi

rjshrjndrn commented 3 years ago

sorry @Thorin-Oakenpants I didn't pursue this issue, as my logged in worked with other browser. I'll check this issue later once I'm free a bit. do you mind keep this open ? or shall we close this one, and add comments as I work on this issue ?

crssi commented 3 years ago

Deactivate (comment-out in user.js) and reset (in about:config) the following to default:

security.cert_pinning.enforcement_level
network.cookie.cookieBehavior
privacy.firstparty.isolate

Maybe the security.cert_pinning.enforcement_level has something to do with ESET, but if I would like login on slack to work here, I need to reset all those. Also note with network.cookie.cookieBehavior... it might work with other settings, but it work as default and definitely doesn't work with value of 1.

Cheers

crssi commented 3 years ago

@rjshrjndrn can you confirm upper solution? If so, then someone should report to mozilla the FPI breakage.

heilrichst commented 1 year ago

I have similar sturuggle. Googles "Sign in with Google" is not properly working, As it doesnt create the popup window, but instead leads to a whithe accounts.google site. Arkenfox is set up by default exept 1601 (setting about cross origin referers) is set to 0. Mabey sb gets the issue an can help.

Thorin-Oakenpants commented 1 year ago

@heilrichst - open a new issue, this one is fucking old and a lot has changed

Mabey sb gets the issue an can help

i do not know what this word salad means - follow the issue instructions and make sure you tried all the steps it links to