search

arkenfox / user.js

Firefox privacy, security and anti-tracking: a comprehensive user.js template for configuration and hardening
MIT License
10.03k stars 514 forks source link

RFP: zoom per eTLD+1 per tab not remembered on some sites #1636

Open practik opened 1 year ago

practik commented 1 year ago

🟥 https://github.com/arkenfox/user.js/wiki/5.2-Troubleshooting

🟪 REQUIRED INFO

practik commented 1 year ago

One more thing: If you set default zoom to anything other than 100% in about:preferences, that setting will be respected when you first open either of those websites I mentioned, but then when you go to any other page on those sites it will open at 100%.

Thorin-Oakenpants commented 1 year ago

RFP ignores site settings for zoom preferences on each new tab, and any eTLD+1 change. It's not meant to "reset" if you stay on the same eTLD+1 in the same tab

using http://www.hdtvsolutions.com/

nothing

just ETP strict

just RFP

won;t check the 4th combo of ETP + RFP

AFAICT this isn't anything to do with ETP, it's RFP and how it's handling the eTLD+1 for some sites ?

Thorin-Oakenpants commented 1 year ago

same with https://www.chicagomanualofstyle.org/ - make sure you use a same eTLD+1, e.g the red box - it's RFP on it's own

FWIW, I changed to ETP standard with RFP and same result

Thorin-Oakenpants commented 1 year ago

@tomrittervg

STR

I wonder if it's the www part causing an issue

edit: regression is in FF94 ... will run moz-regression

Just tested tor browser 12.0.3 based on ESR102 and using http://www.hdtvsolutions.com/ the problem does not exist

regression ended with

INFO : Narrowed nightly regression window ... to [2021-12-15, 2021-12-16] (1 days) (~0 steps left)
Thorin-Oakenpants commented 1 year ago

@practik , see my last comment, last line. I think you're right, this has something to so with ETP (wasn't that switched on by default in FF94?). I bisected my FF portables, which are all defaults except I sanitize on close and a few visual tweaks. 93 was good, 94 was bad

But I ran moz-regression on the whole 94 nightly cycle and came up empty

Thorin-Oakenpants commented 1 year ago

must be something that was backported/flipped - regression is in 97

INFO : Narrowed nightly regression window from [2021-12-15, 2021-12-17] (2 days) to [2021-12-15, 2021-12-16] (1 days) (~0 steps left)
WARNING : Skipping build 646bd6a3104d: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.shippable.revision.646bd6a3104d8a94a342f6de273f829cecf1de50.firefox.win64-opt'
WARNING : Skipping build 66b5b425d27f: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.shippable.revision.66b5b425d27f9880ebde030e4c0a5e433da569ee.firefox.win64-opt'
WARNING : Skipping build 792c9fbceb71: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.shippable.revision.792c9fbceb7170c1c00d8bed57a2c3d2cf6d1913.firefox.win64-opt'
INFO : Stopped
fxbrit commented 1 year ago

this has something to so with ETP (wasn't that switched on by default in FF94?)

what made you think it might be ETP, the TB test? I run mozregression as well but ETP doesn't seem to make a difference.

I also tried on https://www.youtube.com and the www doesn't seem to matter there.

Thorin-Oakenpants commented 1 year ago

what made you think it might be ETP,

just speculation .. you know, urlclassifiers and stuff and TB doesn't use any of ETP (AFAICK). I tried to look at commits on mercurial for 2021-12-16 but not sure how to get an actual list. There were a couple of interesting patches but TBH, IDK what I'm looking for

fxbrit commented 1 year ago

understood. did you fill a ticket at bugzilla or we can avoid that since you tagged Tom above?

not sure how to get an actual list

you could run hg log --date 2021-12-16 --stat in mozilla-central but it's not very telling at first glance..

Thorin-Oakenpants commented 1 year ago

or we can avoid that since you tagged Tom above

we'll see if he pokes his head up, otherwise I might poke him in a week's time

tomrittervg commented 1 year ago

Has this ever worked? The code seems to imply this is what should happen and it's working as 'intended' and has always done that.

Thorin-Oakenpants commented 1 year ago

Has this ever worked

Yes. Issue was not present before - hence moz-regression good vs bad

practik commented 1 year ago

Issue was not present before

Just to confirm this: I use the Chicago site pretty regularly and started noticing the issue there about two weeks ago when I updated to FF 109. It never used to happen before that.