search

arkenfox / user.js

Firefox privacy, security and anti-tracking: a comprehensive user.js template for configuration and hardening
MIT License
9.43k stars 508 forks source link

v128 #1847

Closed Thorin-Oakenpants closed 1 week ago

Thorin-Oakenpants commented 3 weeks ago

something something push notifications requiring service workers?

Maybe. That is true, but it has nothing to do with sanitizing. I went back thru previous versions of arkenfox and this sentence is just weird and left hanging with no context. There's nowhere you can add exceptions for SWers (at least not anymore if ever). I know I put it in for a reason, but it's lost in space-time. I'm ignoring PB mode which currently doesn't have SWers but is also it's own little sanitizing machine.

EDIT: why can't I just leave a comment to one specific commit

you can start a review by commenting on a line in the commit

Jee-Hex commented 3 weeks ago

Maybe. That is true, but it has nothing to do with sanitizing.

Okay it's probably https://github.com/arkenfox/user.js/commit/1fc43574d6cb0a229892738d7b9117a4e4f1fa2c#diff-417e8f625f16252f8ace3b0791d24c9b073d7394e9216c7b5d14a516d2572277L830-L833.

you can start a review by commenting on a line in the commit

Thanks.

Thorin-Oakenpants commented 3 weeks ago

Ok, that rings a bell. I remember testing this. sharedWorkers pref was removed which is why that's gone from the recent versions. I need to think about exactly what this means now, I'm still slightly confused over what exactly I was testing and what I meant

Tiagoquix commented 1 week ago

also, are you going to add the deprecated/removed prefs to prefs cleaner or that is not necessary?

additional question: in the deprecated/removed section, shouldn't user_pref lines always be commented (even if they're on a multiple-comment already)? (i.e. always //user_pref - dunno, seems more "correct" to me)

Thorin-Oakenpants commented 1 week ago

are you going to add the deprecated/removed prefs to prefs cleaner or that is not necessary?

deprecated/removed prefs are in the user.js - therefore they are already covered by prefsCleaner

additional question

the entire section is commented out, but users can flip the section, e.g. if they use ESR

Thorin-Oakenpants commented 1 week ago

this PR is fucked - i can't resolve the conflict that doesn't fucking exist