arkflame / SquidGame

Minecraft Minigame inspired by the famous and trending Netflix series "Squid Game"
https://www.spigotmc.org/resources/%E2%9C%A6-squidgame-%E2%9C%A6-multiarena-placeholder-api-support-free.96874/
39 stars 16 forks source link

Use PaperLib for plugin teleports #29

Closed 4drian3d closed 2 years ago

4drian3d commented 3 years ago

In case the plugin is executed in Paper 1.9+ and especially in Paper 1.15.2+ it will use its asynchronous teleport. Otherwise, it will use the classic and heavy Bukkit/Spigot teleport.

In addition...

linsaftw commented 3 years ago

Will this crash on 1.7+ servers?

4drian3d commented 3 years ago

Will this crash on 1.7+ servers?

What PaperLib does is, depending on the server version, use one method or another. If running on Spigot/CraftBukkit 1.7-1.17 it will use the classic Bukkit Entity#teleport(Location), but if running on a Paper 1.9 server it will use the Paper teleport enhancements and if running on Paper 1.15.2+ it will use the Entity#teleportAsync(Location).

You could do a similar logic in the own plugin, but you would have to rely on Paper 1.17.1 or use reflection.

In short, you should have no problems on 1.7 servers.(Not tested)

4drian3d commented 3 years ago

The purpose of this pull request is to fix a plugin issue seen at https://discord.com/channels/442079515498381312/899052976499462165/901543458366423090.

linsaftw commented 3 years ago

The purpose of this pull request is to fix a plugin issue seen at https://discord.com/channels/442079515498381312/899052976499462165/901543458366423090.

Please take a screenshot of the error.

Will this work on 1.7+ servers?

4drian3d commented 3 years ago

Answered 2 weeks ago via discord

The plugin works correctly on Spigot/Paper servers and forks 1.8-1.17.1 There is no compatibility with 1.7 in the plugin, but if so, this change would still be compatible.

It's not a "error", just the slow teleporting of bukkit that can cause bad gaming experiences.

KaspianDev commented 2 years ago

The purpose of this pull request is to fix a plugin issue seen at https://discord.com/channels/442079515498381312/899052976499462165/901543458366423090.

Please take a screenshot of the error.

Will this work on 1.7+ servers?

who cares about 1.7 XDD

linsaftw commented 2 years ago

The purpose of this pull request is to fix a plugin issue seen at https://discord.com/channels/442079515498381312/899052976499462165/901543458366423090.

Please take a screenshot of the error. Will this work on 1.7+ servers?

who cares about 1.7 XDD

I meant for 1.8, 1.9, etc support.

4drian3d commented 2 years ago

The purpose of this pull request is to fix a plugin issue seen at https://discord.com/channels/442079515498381312/899052976499462165/901543458366423090.

Please take a screenshot of the error. Will this work on 1.7+ servers?

who cares about 1.7 XDD

I meant for 1.8, 1.9, etc support.

I tested its correct functionality a few weeks ago

KaspianDev commented 2 years ago

legacy versions should die already

linsaftw commented 2 years ago

legacy versions should die already

when mojang decides to stop fucking up their game, lol.