arkhipov / temporal_tables

Temporal Tables PostgreSQL Extension
BSD 2-Clause "Simplified" License
927 stars 46 forks source link

Windows DLLs need VCRUNTIME140.DLL #16

Closed gosanefr closed 8 years ago

gosanefr commented 8 years ago

Please add a note stating that current Windows DLL require VCRUNTIME140.DLL are installed. This is provided by the Visual C++ Redistributable for Visual Studio 2015 downloadable from Microsoft here :

https://www.microsoft.com/en-US/download/details.aspx?id=48145

arkhipov commented 8 years ago

This issue seems to be already fixed in 1.1.0. Have you tried master builds on AppVeyor?

mlt commented 8 years ago

I think this can be closed. It was fixed indeed. Also I checked that current 9.6 beta also still uses 120 platform.

gosanefr commented 8 years ago

It's not a bug that needs to be fixed : the binaries are what they are but temporal_tables-1.0.2 (the "latest" as referenced here : https://github.com/arkhipov/temporal_tables/releases/latest ) are linked to VCRUNTIME140.DLL so you need this installed on the server in order to CREATE EXTENSION (or you get an "Unknown error 126" IIRC)

I don't know where to get the 1.1.0 build (I see the logs on AppVeyor but no download link).

mlt commented 8 years ago

@gosanefr The one in Releases on GitHub is outdated in this sense. AppVeyor calls it artifact. Choose your configuration and click on ARTIFACTS in top right corner.

@arkhipov There is a way to push artifacts into github Releases section upon successful build. I never attempted that and it seems might be cluttering github's download section. But IIRC there is a way to push binaries for tagged commits only.

gosanefr commented 8 years ago

@mlt Thanks, found the artifacts. Unfortunately, I need x86 builds.

arkhipov commented 8 years ago

I have just released the 1.1.0 version. @gosanefr, could you please check if it works for you?

gosanefr commented 8 years ago

It's perfect, thank you.