search

arkhipov / temporal_tables

Temporal Tables PostgreSQL Extension
BSD 2-Clause "Simplified" License
937 stars 47 forks source link

Bump PG versions +10 with AppVeyor #33

Closed mlt closed 7 years ago

mlt commented 7 years ago

Upd... it looks like it is more involving than I thought :innocent: https://gist.github.com/mlt/177aa3f1271410fd265978ba09daafe4

SPI_modifytuple returns NULL for whatever reason. Do we need to check in the code?

SPI_result was set to SPI_ERROR_UNCONNECTED

This might be relevant

mlt commented 7 years ago

Done? Let me know if you would like me to redo something. Otherwise, I'd rebase the branch (to apply fixup) and it is ready to go.

Shall I replace PointerGetDatum with PG_RETURN_POINTER while at it?

arkhipov commented 7 years ago

Thank you, @mlt. PointerGetDatum seems OK to me in a static function.