arkhitech / redmine_mentions

Allows users to mention team members in their notes/comments.

MIT License

94 stars 88 forks source link

Fixed mailing issue in redmine 4.0.0 #68

Open LaurensRietveld opened 5 years ago

LaurensRietveld commented 5 years ago

This solves #67

Disclaimer: not a ruby developer ;)

keysen commented 5 years ago

No this fix is so complicated.

A better one could be to replace app/models/mention_mailer.rb:9

# from:
Mailer.default_url_options 
# to:
::Mailer.default_url_options

Then it's working ^^

The reason is Mailer is an already existing class and on this line it doesn't resolve with the right Mailer class.

sraskin commented 5 years ago

No this fix is so complicated.

A better one could be to replace app/models/mention_mailer.rb:9
# from:
Mailer.default_url_options 
# to:
::Mailer.default_url_options
Then it's working ^^

The reason is Mailer is an already existing class and on this line it doesn't resolve with the right Mailer class.

Thanks, man! its working

tainewoo commented 5 years ago

No this fix is so complicated.

A better one could be to replace app/models/mention_mailer.rb:9

from:

Mailer.default_url_options

to:

::Mailer.default_url_options

Then it's working ^^

The reason is Mailer is an already existing class and on this line it doesn't resolve with the right Mailer class.

Yes it works for me too.

gsancewicz commented 5 years ago

@keysen

No this fix is so complicated.

A better one could be to replace app/models/mention_mailer.rb:9
# from:
Mailer.default_url_options 
# to:
::Mailer.default_url_options
Then it's working ^^

The reason is Mailer is an already existing class and on this line it doesn't resolve with the right Mailer class.

Maybe you should add this as pull request. This fix works for us too.