search

arkhitech / redmine_mentions

Allows users to mention team members in their notes/comments.
MIT License
98 stars 88 forks source link

Prevent double notifications if redmine mention sent. #75

Open kporras07 opened 4 years ago

kporras07 commented 4 years ago

Hi,

Thanks for such a great plugin. I'd like to contribute my solution to #28

Any feedback is welcome :)

hishammalik commented 4 years ago

Thank you for the contribution! However, this goes against the redmine notifications settings as users who are expecting to receive notifications will all of a sudden realize that they are not receiving notifications.

Correct patch would be to add configurations related to email notification settings under user to allow for options like "Only for events when no one is mentioned", etc. See screenshot for the notification settings:

Screenshot 2020-07-24 11 55 56
kporras07 commented 4 years ago

@hishammalik thanks for your feedback. I'm kind of new to Ruby and I'm not really getting to fix this as suggested.

I've found that the options are defined in User::MAIL_NOTIFICATION_OPTIONS constant; but I haven't found how to override that constant in a patch. I'd be happy to update the PR if you can point me to how to override the constant in a patch.

unknown2222 commented 1 week ago

Any updates?