arkhitech / redmine_timesheet_plugin

This is a Redmine 2+ compatible version of plugin originally created by Eric Davis to generate timesheets from timelogs.
https://github.com/arkhitech/redmine_timesheet_plugin.git
Other
42 stars 47 forks source link

Fix issue #60 with 'unknown column projects.status' and CSV export problem #63

Closed SashaH closed 7 years ago

ghost commented 8 years ago

About the csv export method, you need to add a condition when the date_from / date_to are empty. This happens when you select "all" in the period's select input. It will return date_from=Timesheet[date_from].

I was making changes but i can't find the solution because @timesheet dont return the period attribute value .

Beside this little problem, works like a charm. Thanks

EDIT:

I used this ugly code to avoid the problem :

if param=="timesheet[date_from]=" && @timesheet.period_type == 1
          inputs << hidden_field_tag(param_arr.first, "1950-01-01" ,:id => "")
        elsif param=="timesheet[date_to]=" && @timesheet.period_type == 1
          inputs << hidden_field_tag(param_arr.first, "2050-01-01" ,:id => "")
        else
          inputs << hidden_field_tag(param_arr.first, param_arr.last  , :id => "")
end
VVD commented 7 years ago

SashaH, can you commit changes to master branch? Or you can just fork it and fix all these bugs.

SashaH commented 7 years ago

VVD, I can work only in my fork.

VVD commented 7 years ago

SashaH, can't find your fork: https://github.com/p-h-i-l/redmine_timesheet_plugin/network/members

alxwr commented 6 years ago

@VVD fwiw: the fork is here: https://github.com/speedandfunction/redmine_timesheet_plugin