arkhn / Cohort360

A web application to find patients, build cohorts and visualize data
Apache License 2.0
0 stars 0 forks source link

Afficher tout type de valeur dans les résultats de biologie #101

Closed elsiehoffet-94 closed 3 years ago

elsiehoffet-94 commented 3 years ago

Description

Pour le moment, seulement les attributs de type ValueQuantity sont affichés correctement dans les résultats de bio, alors qu'il existe des résultats de type ValueString, ValueBoolean, ValueRatio etc..

En particulier, on a besoin de résultats de type ValueString pour un type de résultats spécifique.

MiskoG commented 3 years ago

Alright, so I checked Cohort and it seems that the current behaviour is as followed (screenshot from demo env)

image

What I suggest for now is handling this attributes

image

Using this logic in front

I intentionally didn't say "else if" but "if-s" just to avoid missing some information if an Observation happen to have several of these attributes. This could lead to a situation where there are multiple values displayed in a single line. We will see in reality if this happens and how to handle it properly.

elsiehoffet-94 commented 3 years ago

Seems like a good approach! I think we will face other issues in the near future but it's a good start :)

nriss commented 3 years ago

I agree, it seems great! According to me, the interpretation attribute must be shown somewhere else (maybe on result hover ?) But showing everything is clearly a good start !

tevariou commented 3 years ago

I agree, it seems great! According to me, the interpretation attribute must be shown somewhere else (maybe on result hover ?) But showing everything is clearly a good start !

so what do I do for the interpretation result ? I can display a supplementary column for this

tevariou commented 3 years ago

Using this logic in front

  • If there is a valueQuantity, show it (value + unit)
  • If there is a valueString, show the string
  • If there is a valueBoolean, show TRUE or FALSE
  • If there is a valueInteger, show the integer
  • If there is an interpretation, show it

I intentionally didn't say "else if" but "if-s" just to avoid missing some information if an Observation happen to have several of these attributes. This could lead to a situation where there are multiple values displayed in a single line. We will see in reality if this happens and how to handle it properly.

you can't have multiple kinds of value according to the spec

nriss commented 3 years ago

Right! But you can have a value and an interprétation, so multiple results to show

elsiehoffet-94 commented 3 years ago

I think your PR is sufficient for now. Interpretations could appear somewhere else, on-click or on hover for instance. This would depend on user feedback I guess? We will also have to handle component attributes, (when we have multiple results like diastolic + systolic blood pressure), but it's not a huge priority. We can create an issue and investigate solutions ?