search

arkhn / Cohort360

A web application to find patients, build cohorts and visualize data
Apache License 2.0
0 stars 0 forks source link

"Documents" section doesn't list any document in Toulouse env #113

Open MiskoG opened 3 years ago

MiskoG commented 3 years ago

Spotted by @elsiehoffet-94 image

Seems like we have a bad request on the DocumentReference FHIR endpoint. I think there is an easy fix but I'm not sure, what do you think @simonvadee ?

simonvadee commented 3 years ago

I identified the issue, it's partly due to a mapping issue on DocumentReference and also because the cohort app is not flexible at all. I'm fixing this thanks to @Peltier10 help.

MiskoG commented 3 years ago

Ok great ! Does fixing this imply only modifying the mapping, or also make Cohort more flexible in this case ?

simonvadee commented 3 years ago

We need to modify both. Should be done tomorrow.

simonvadee commented 3 years ago

don't have time to finish this sorry: For @Jasopaum : in src/components/Cohort/Documents/DocumentList/DocumentList.tsx: the file url needs to start with file:// and end with.pdf. We only use the first extension but sometimes there are multiple ones (for tls, there are three sections). You need to adapt src/components/Cohort/Documents/PdfRenderer/PdfRenderer.tsx to accept multiple sections

Jasopaum commented 3 years ago

don't have time to finish this sorry: For @Jasopaum : in src/components/Cohort/Documents/DocumentList/DocumentList.tsx: the file url needs to start with file:// and end with.pdf. We only use the first extension but sometimes there are multiple ones (for tls, there are three sections). You need to adapt src/components/Cohort/Documents/PdfRenderer/PdfRenderer.tsx to accept multiple sections

I don't think this was really the answer to this issue. The problem was that the api response was an empty bundle when trying to sort on the search param date. I removed the sorting for now but we need to investigate

MiskoG commented 3 years ago

I removed the sorting for now but we need to investigate

@Jasopaum Can we consider this initial bug/issue as fixed ? Is there any PR associated with the sort removing ?