search

arkhn / Cohort360

A web application to find patients, build cohorts and visualize data
Apache License 2.0
0 stars 0 forks source link

Pass groupId to jpyltime instead of list of patientIds #30

Closed Jasopaum closed 3 years ago

Jasopaum commented 3 years ago

Is it normal that the export button is always displayed in the TopBar?

🚧 We'll wait for the jpyltime api to be updated before merging this 🚧

BPierrick commented 3 years ago

Is it normal that the export button is always displayed in the TopBar?

It's kind of badly designed.

I personally think the RedcapExport component should be placed in the same component as its open button, that way the context can disable this button regarding the exploration type we're doing (cohort, perimeter, patients,...)

So if we want to disable the button (but keeping it in the topbar), we will have to do this I guess, or else export logic will be split in both components TopBar & Dashboard