Show cohort dashboard when members out of scope

arkhn / Cohort360

A web application to find patients, build cohorts and visualize data

Apache License 2.0

0 stars 0 forks source link

Show cohort dashboard when members out of scope #49

Closed BPierrick closed 3 years ago

BPierrick commented 3 years ago

Description

Changes in the display behavior of a cohort dashboard :

When no members are in the group (even though they're not in the practitioner's perimeter), the red alert still shows
When there are members in and out of the group, display stays the same as before
When there are group members and they're all out of the practitioner's perimeter, the dashboard shows as this :

Regarding the dashboard displayed infos, one change is noticeable :

The patients count (top left of the dashboard) now refers the group.member length, and not the api fetch patients count (which are filtered by perimeter)

MiskoG commented 3 years ago

@BPierrick Can we just show a bar in the graph, for the group members (or patients) that are not yet in your perimeters ?

Like this

It's weird to have a label like "Cardiologie" and nothing above it. I interpret it as "no patient" for this perimeter which is not the same.

The rest seems fine !

BPierrick commented 3 years ago

Can we just show a bar in the graph, for the group members (or patients) that are not yet in your perimeters ?

I don't think it is possible to display accurate values. I can know that patients are in the group, but there is no way of knowing in which organization they belong

simonvadee commented 3 years ago

I thought we could find a workaround for this but the permissioning model is so 💪 that we cannot see how many patients belong to organizations we don't have access to (technical details: we use Encounter to join between patients and orga, so we would need to adapt permissions on Encounter to resolve this) Here's a UI fix I can think of: display a bar of arbitrary length, independently of how many patients really belong to the orga. what do you guys think ?

MiskoG commented 3 years ago

That's just what I suggested to Pierrick, what a soul connection <3 Actually we can even set a not-so-arbitrary length : (total nb of patients) - (sum of patients from authorized perimeters) divided by the number of (perimeters which I don't have access to)

BPierrick commented 3 years ago

I have set mean values of "patients out of perimeter" per "orga out of perimeter" (cf screenshot in PR description)

MiskoG commented 3 years ago

Great ! 👍