Added snackbar in AccessRequests component

BPierrick commented 3 years ago

Fixes

Fixes #80 by @MiskoG

Description

Use of material-ui Snackbar component
Handle access updates and failures with severities respectively success & error

Screenshots

MiskoG commented 3 years ago

@BPierrick Awesome !

I just have a doubt concerning the scenario where the snackbar is red - I understand what was your intention (red = refusal) but here the user is the administrator. And generally speaking in UI, a red thing is used for dangerous actions (= delete for example) or errors.

I feel it would be safer to just show a green snackbar everytime with for example "Votre réponse a bien été prise en compte". Bonus : we can keep the red snackbar when the API response is an error, with something like "Une erreur est survenue. Votre réponse n'a pas pu être prise en compte."

simonvadee commented 3 years ago

I agree with @MiskoG, the red snackbar should only be used for api errors

MiskoG commented 3 years ago

Exactly 👍

arkhn / Cohort360