arkhn / Cohort360

A web application to find patients, build cohorts and visualize data
Apache License 2.0
0 stars 0 forks source link

As a user I can see the diagnosis codes and search them when adding a diagnosis cohort criteria #93

Closed elsiehoffet-94 closed 3 years ago

elsiehoffet-94 commented 3 years ago

Problème

Dans l'ajout de critères pour créer une cohorte, dans PMSI> Diagnostics, il faudrait pouvoir choisir parmi les codes de la CIM-10, (aujourd'hui CIM-9 uniquement). Il faudrait aussi pouvoir rechercher par code et pas par libellé uniquement.

Description

Ce que ça implique :

Contexte

Remarques soulevées par @Peltier10

elsiehoffet-94 commented 3 years ago

linked to #94

nriss commented 3 years ago

Originally, Cohort360 has been developed using mimic-iii, which uses icd-9 classification! I think it's just hard written 'icd-9', there is just a text correction to do, maybe replace by 'icd-9/icd-10 code', 'Condition code', 'Code pathologie' or something like that

I think we are just looking on the code search param of the Condition resource without regarding any system. And according to me, today, we can search using the code but not the display ? (@tevariou is it right ?)

We can create 3 VS:

On the page, it could be cool to have a textbox / multiple selectbox with an autocomplete to choose among all pathology terminologies

elsiehoffet-94 commented 3 years ago

Thanks a lot for this clarification, it's much clearer :)

I think we are just looking on the code search param of the Condition resource without regarding any system. And according to me, today, we can search using the code but not the display ? (@tevariou is it right ?)

Today, it's only possible to select an item from the dropdown, but the front does not allow typing a code. I think we should fix this in the front, without waiting for any design decision at this point.

We should definitely keep multiple terminologies, and discuss a bit more about the best way to handle those with @MiskoG . I don't think a comprehensive valueSet is the most appropriate way for ICD-*, it means creating a valueSet of >16K codes.

MiskoG commented 3 years ago

Indeed, as a reminder today it works like this

image

➡️ We can put whatever codes we want in our ValueSet. So maybe we could handle the situation this way, as long as there is only one terminology used for diagnosises :

image

As long as there is only one terminology (or ValueSet) used this solution works. When we will have multiple terminologies, then I guess the solution will be a bit more complex.

What do you guys think @elsiehoffet-94 @nriss ?

nriss commented 3 years ago

A ValueSet containing all icd-10 codes called CohortConditionsVS has been added to the cohort360 ig (discussed with @tevariou )

MiskoG commented 3 years ago

Right, so maybe the first implementation would be to "just" link the frontend to this CohortConditionsVS, and then also add the code of each element of the ValueSet so that it is shown to the user and is searchable.

nriss commented 3 years ago

Totally agree with you @MiskoG !

For now, we can add all icd-10 codes for now and then adapt to a subset of codes if needed by the current situation

MiskoG commented 3 years ago

I'm still a bit confused about how to show the code (D17.1 for instance) of each element in front. I guess it is directly written in the ValueSet for each element, or in the original CodeSystem ?

nriss commented 3 years ago

The CodeSystem define the terminology but does not necessarily contain the codes The expanded ValueSet contain all codes and display, as shown in this expansion array

According to me, it could be cool to show both code and display as you said

MiskoG commented 3 years ago

Ok great :)

Also, when we need to adjust the ValueSet linked to Cohort, should we have some sort of config file to do that ? In order to not modify Cohort code directly in each center

nriss commented 3 years ago

It would be so cool to give the possibility to change the ValueSet.url of the desired VS on cohort settings!

In that case, if we want to change the VS, we will just have to:

and it works! 🚀

MiskoG commented 3 years ago

Alright so I created an issue for that. I suggest that in this current issue, we just focus on displaying the codes to the user and being able to search them 🔍

MiskoG commented 3 years ago

@tevariou Do you want to take this one ? I'm available to clarify stuff if needed

tevariou commented 3 years ago

@MiskoG yep!