redis counter `failed_counters` is never created

[simonvadee]

Description

When hapi-loader fails to insert a resource, it is supposed to increment a redis counter called failed_counters. Apparently this never happens, which prevents the batch from being ever deleted (and this is bad).

Reproduction

1. Run a batch with errors (eg: on a resource with an unknown resource_type such as bp on Observation)
2. check hapi-loader logs, it should say Could not parse resource: unknown resource_type blabla
3. Check the redis counters:

   docker exec `docker ps -q -f "name=redis"` redis-cli KEYS "*"

4. See error.

Expectation

When running e2e tests locally, it works. When running on remote testy host, it doesn't. Please fix

Resolution

the hell I know

[simonvadee]

it works fine