arkhometha / Historical-Project-Mod

A mod for Victoria 2 - Heart of Darkness 3.04
157 stars 52 forks source link

free_botswana and Lourenco Marques fixes #220

Open cetvrtak opened 3 years ago

cetvrtak commented 3 years ago
  1. Free Botswana decision - release_vassal = TSW requires them to be a vassal already to release from that status. Use release = TSW create_vassal = TSW

  2. Getting Lourenço Marques event - although not an error, it would be better to scope to the state from a province already checked in the trigger - 2049 or 2050 instead of 2051

moretrim commented 3 years ago
  1. Free Botswana decision - release_vassal = TSW requires them to be a vassal already to release from that status. Use release = TSW create_vassal = TSW

release_vassal has two functions:

Looking at the decision requirements it looks to me that the first role is intended here:

https://github.com/arkhometha/Historical-Project-Mod/blob/a181b6c01ed76b460bb4a21cb2cedc4aa0c35836/HPM/decisions/New%20Colonies.txt#L7280

This seems entirely appropriate for creating a colonial puppet to me.

In contrast, release makes the argument country undergo the same process as during loading a new campaign, by reading from the history files.