I noticed a few shortcomings when going over the Colonial Organisation system. Most notably an African AI country may organise e.g. Indonesia, but a player country may not. This PR tries to remove all disparities between player and AI by having turn_on_organize_colony_decisions closely mirror the decisions it gates. Another benefit of doing so is eliminating e.g. false positives where the de-clutter decision lights up, but no actual organisation decision is available to activate.
Because this change generates a lot of churn, I’ve carefully laid it out in a series of patches. I recommend going over them in order for review purposes. Also bundled in the PR:
whitespace fixes
extra cost/debt red warnings
minor localisation editorial fixes
I have not tested this PR.
Reasons to reject this PR
If I have misjudged the situation and it is AI African countries which are not supposed e.g. to organise Indonesia, this is not the right fix. In which case I can happily split off the unrelated localisation fixes.
I noticed a few shortcomings when going over the Colonial Organisation system. Most notably an African AI country may organise e.g. Indonesia, but a player country may not. This PR tries to remove all disparities between player and AI by having
turn_on_organize_colony_decisionsclosely mirror the decisions it gates. Another benefit of doing so is eliminating e.g. false positives where the de-clutter decision lights up, but no actual organisation decision is available to activate.Because this change generates a lot of churn, I’ve carefully laid it out in a series of patches. I recommend going over them in order for review purposes. Also bundled in the PR:
I have not tested this PR.
Reasons to reject this PR
If I have misjudged the situation and it is AI African countries which are not supposed e.g. to organise Indonesia, this is not the right fix. In which case I can happily split off the unrelated localisation fixes.