arkhometha / Historical-Project-Mod

A mod for Victoria 2 - Heart of Darkness 3.04
157 stars 52 forks source link

[BUG]Code in the poptypes files that seems odd #240

Open ihavesomethingtoask opened 3 years ago

ihavesomethingtoask commented 3 years ago

Most pops have the following modifier within country_migration_target:

modifier = {
    factor = 3.7
    NOT = { total_pops = 500000 }
    NOT = { number_of_states = 2 }
    has_country_flag = new_world_nation
    OR = {
        capital_scope = { is_colonial = no continent = north_america }
        capital_scope = { is_colonial = no continent = south_america }
        capital_scope = { is_colonial = no continent = australia_new_zealand }
    }
    OR = {
        government = democracy
        government = presidential_dictatorship
        government = hms_government
    }
}

As I understand it, this boost migration to countries that have 1 state and have less than 500000 people. It's the second of these criteria that strikes me as odd, since I don't understand why'd you'd want to boost migration to small countries in particular. That has made me wonder whether there wasn't supposed to be a NOT operator there and that the intend was to boost migration to countries with two states or more that have a small population, as these would be relatively empty.