cluster-create now tags the OS Domain

arkime / aws-aio

Apache License 2.0

8 stars 3 forks source link

cluster-create now tags the OS Domain #115

Closed chelma closed 1 year ago

chelma commented 1 year ago

Description

Updated cluster-create to tag the OS Domain with the cluster name
Minor fixes to the detailed design diagram

Tasks

https://github.com/arkime/aws-aio/issues/114

Testing

Add unit tests
Tested in my own AWS account by running cluster-create on an existing domain and making sure the tag appeared:

arkime_domain_tag

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

chelma commented 1 year ago

LGTM, do you think in the future we should also do other high level items like S3 bucket and VPC?

Not a bad idea. Maybe we should tag all the "sticky" resources that are likely to be left over after a default cluster-destroy, which includes the OS Domain, the VPC, the S3 Bucket, the KMS Key(s), etc...