arkime / aws-aio

Apache License 2.0
8 stars 3 forks source link

CLI lets users `cluster-destroy` when VPCs are still attached #149

Closed chelma closed 7 months ago

chelma commented 8 months ago

Description

This task is to update the behavior of cluster-destroy to ensure that users have removed all VPCs from the Cluster's capture portfolio before being able to terminate the Cluster.

Acceptance Criteria

chelma commented 7 months ago

We apparently already check for this:

(.venv) chelma@3c22fba4e266 aws-aio % ./manage_arkime.py --region us-east-1 cluster-destroy --name MyCluster --retain
-traffic-data
2024-01-19 15:11:44 - Debug-level logs save to file: /Users/chelma/workspace/Arkime/aws-aio/manage_arkime/manage_arkime.log
2024-01-19 15:11:44 - Using AWS Credential Profile: None
2024-01-19 15:11:44 - Using AWS Region: us-east-1
2024-01-19 15:11:45 - Your cluster is currently monitoring VPCs.  Please stop monitoring these VPCs using the vpc-remove command before destroying your cluster:
['vpc-0d7c85206deffbdbb']
2024-01-19 15:11:45 - Aborting...

See: https://github.com/arkime/aws-aio/blob/e679663ab65488802881cc7c7171c45903449a1d/manage_arkime/commands/cluster_destroy.py#L30

chelma commented 7 months ago

No work to do; resolving.