arkime / aws-aio

Apache License 2.0
8 stars 3 forks source link

use the cdk binary from node_modules instead of path #151

Closed awick closed 7 months ago

awick commented 7 months ago

Description

Instead of relying on our path for the cdk binary, use the one that was installed by the aws-cdk nodejs package

Tasks

N/A

Testing

Ran create-cluster which uses the cdk path and it worked fine.

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

chelma commented 7 months ago

The CI tests are failing because I rejiggered our test stack to pass for another PR with backwards incompatible changes (https://github.com/arkime/aws-aio/pull/152). They're failing in exactly the way I'd expect given the situation, and so will approve the change despite the failing tests.