Capture VPC now present in all AZs

chelma commented 7 months ago

Description

An error occurred when users tried to add VPCs to an Arkime Cluster that were present in AZs the Cluster's Capture VPC wasn't in. This was due to the GWLB needing a Target in every AZ that it needed to create a VPC Endpoint in. In order for the GWLB to have a Target in every AZ, the Capture Node's ASG must be present in every AZ (even if it currently has no provisioned instances in the AZ).
The solution was to update the Capture VPC to provision subnets in every AZ in the region and have the Capture Node ASG span all of those subnets. This "enabled" every AZ from the GWLB's perspective. Cross-zone load balancing is enabled on the GWLB/ASG combo so that we don't have to have a Capture Node in every AZ.
This is a backwards-incompatible change because we had to modify how we store our VPC Plan in Param Store, so the major version has been bumped.

Tasks

https://github.com/arkime/aws-aio/issues/147

Testing

I updated the Demo Traffic CDK to provision our test instances in every AZ (6, in us-east-1), then ensured that I was able to run cluster-create and vpc-add on the Demo VPC. I then confirmed that test traffic from AZs that we did not have Capture Nodes in still were being captured by searching for those test instance's private IPs on the Arkime Portal. Everything seemed to still work correctly.

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

chelma commented 7 months ago

Since the change I made was backwards incompatible, and we retain the Arkime Cluster we use in our GitHub Actions CI system between tests, cluster-create is currently failing. Looking into the best solution.

chelma commented 7 months ago

The fix was to manually tweak the Param Store entry for the cluster this time

chelma commented 7 months ago

Made the mistake of rebasing locally due to https://github.com/arkime/aws-aio/pull/151, had to force-push onto this branch to retain this PR.

chelma commented 7 months ago

OK - I think the latest version of the capacity planning code will satisfy everyone

arkime / aws-aio