search

arkime / aws-aio

Apache License 2.0
8 stars 3 forks source link

CLI doesn't warn when operating against incompatible AWS_AIO_VERSION #154

Closed chelma closed 7 months ago

chelma commented 7 months ago

Description

As we rapidly develop this project, we need to be careful to ensure that backwards incompatible changes are communicated to the user. A key part of this is the AWS_AIO_VERSION [1] number, which we use to track these sorts of changes. When a backwards incompatible change is made, this number should be incremented.

Currently, we don't proactively warn users when they are about to perform an operation that is likely to fail due to the CLI version not matching the Arkime Cluster version. We should warn the user and/or abort if they are about to perform a cross-version operation and provide guidance for how to revert to the correct version of the CLI.

[1] https://github.com/arkime/aws-aio/blob/main/manage_arkime/core/versioning.py#L12

chelma commented 7 months ago

There appears to be two parts to resolving this issue:

  1. Detecting in the CLI when there is a version mismatch and warning the user
  2. Providing a way for the user to get a compatible version of the CLI

An additional, third part with much larger scope exists too:

  1. Make it possible to migrate between versions of the AWS AIO solution
chelma commented 7 months ago

Code has been merged; resolving.