Added AWS AIO Version compatibility checks to the vpc-add and vpc-remove commands. I had originally thought this would require backwards incompatible changes but that fortunately turned out not to be the case.
I also fixed a circular import dependency issue by moving some code from core.versioning to its own, new file core.compatibility. It had existed in the previous commit but only popped up under very specific circumstances. I stumbled across it while updating the behavior of vpc-add.
(.venv) chelma@3c22fba4e266 aws-aio % ./manage_arkime.py --region us-east-1 vpc-add --cluster-name MyClusterV2 --vpc-id vpc-0fc8b977a31286213
2024-01-24 16:23:22 - Debug-level logs save to file: /Users/chelma/workspace/Arkime/aws-aio/manage_arkime/manage_arkime.log
2024-01-24 16:23:22 - Using AWS Credential Profile: None
2024-01-24 16:23:22 - Using AWS Region: us-east-1
2024-01-24 16:23:26 - The AWS AIO versions of your CLI (3) and Cluster (2) do not match. This is likely to result in unexpected behavior. Please change your CLI to the latest minor version under the
major version (2). Check out the following README section for more details: https://github.com/arkime/aws-aio#aws-aio-version-mismatch
2024-01-24 16:23:26 - Aborting...
(.venv) chelma@3c22fba4e266 aws-aio % ./manage_arkime.py --region us-east-1 vpc-remove --cluster-name MyClusterV2 --vpc-id vpc-0fc8b977a31286213
2024-01-24 16:23:35 - Debug-level logs save to file: /Users/chelma/workspace/Arkime/aws-aio/manage_arkime/manage_arkime.log
2024-01-24 16:23:35 - Using AWS Credential Profile: None
2024-01-24 16:23:35 - Using AWS Region: us-east-1
2024-01-24 16:23:37 - The AWS AIO versions of your CLI (3) and Cluster (2) do not match. This is likely to result in unexpected behavior. Please change your CLI to the latest minor version under the
major version (2). Check out the following README section for more details: https://github.com/arkime/aws-aio#aws-aio-version-mismatch
2024-01-24 16:23:37 - Aborting...
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Description
vpc-addandvpc-removecommands. I had originally thought this would require backwards incompatible changes but that fortunately turned out not to be the case.core.versioningto its own, new filecore.compatibility. It had existed in the previous commit but only popped up under very specific circumstances. I stumbled across it while updating the behavior ofvpc-add.Tasks
Testing
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.