search

arkitektio / arkitekt

arkitekt is the python api client for the arkitekt-framework
https://arkitekt.live
MIT License
2 stars 1 forks source link

Development #8

Closed jhnnsrs closed 7 months ago

jhnnsrs commented 7 months ago

Massive refactor

gitguardian[bot] commented 7 months ago

⚠️ GitGuardian has uncovered 46 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/port.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-7ba4e7a196b0ecf33177bba737a4666cL5) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/docker-compose.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-a4d53fbf2af2b3275dfd1bf64303f9ceL5) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/lok.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-699fbd255732c65d3b957415cfd59c04L46) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/mikro.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-b7b9de0479b18d1bb34547fa3385f613L5) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/fluss.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-beb528fb07c3513b6d4a19eeb58f54bfL5) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/rekuest.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-2d1eb628901c9021c6ea719386881935L5) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL568) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 57a61c6cae376be42fb9daf9de52150860667d5f | examples/com.example.random_shapes-latest_cache.json | [View secret](https://github.com/jhnnsrs/arkitekt/commit/57a61c6cae376be42fb9daf9de52150860667d5f#diff-f1c1569a8b11c4c493f361c6b92b75ffL1) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/minio.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-0ea75d64e620cdd498b1c7fd86ed6790L25) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/mikro.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-b7b9de0479b18d1bb34547fa3385f613L30) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/minio.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-0ea75d64e620cdd498b1c7fd86ed6790L15) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/minio.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-0ea75d64e620cdd498b1c7fd86ed6790L30) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Private Key | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/lok.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-699fbd255732c65d3b957415cfd59c04L71) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Django Secret Key | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/mikro.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-b7b9de0479b18d1bb34547fa3385f613L16) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Database Assignment | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL2) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/minio.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-0ea75d64e620cdd498b1c7fd86ed6790L40) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/lok.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-699fbd255732c65d3b957415cfd59c04L70) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/minio.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-0ea75d64e620cdd498b1c7fd86ed6790L35) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/fluss.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-beb528fb07c3513b6d4a19eeb58f54bfL28) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL250) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/docker-compose.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-a4d53fbf2af2b3275dfd1bf64303f9ceL35) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL587) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/docker-compose.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-a4d53fbf2af2b3275dfd1bf64303f9ceL63) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 57a61c6cae376be42fb9daf9de52150860667d5f | com.example.test-latest_cache.json | [View secret](https://github.com/jhnnsrs/arkitekt/commit/57a61c6cae376be42fb9daf9de52150860667d5f#diff-2998fc5002a42bf4bdbb6fa88f372024L1) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | com.example.test-latest_cache.json | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-2998fc5002a42bf4bdbb6fa88f372024R1) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/minio.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-0ea75d64e620cdd498b1c7fd86ed6790L20) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 49bf1176f93d5997f6facc1d7c32a9cb08781fe4 | examples/integration/elab_integration.py | [View secret](https://github.com/jhnnsrs/arkitekt/commit/49bf1176f93d5997f6facc1d7c32a9cb08781fe4#diff-41d09473adf127c578e11557744fe6c5L9) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Django Secret Key | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/lok.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-699fbd255732c65d3b957415cfd59c04L59) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Company Email Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/mikro.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-b7b9de0479b18d1bb34547fa3385f613L11) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Company Email Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/lok.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-699fbd255732c65d3b957415cfd59c04L54) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Company Email Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/port.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-7ba4e7a196b0ecf33177bba737a4666cL11) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Company Email Password | f7c95caad7efbca15824261c911df7775646ec15 | website/setup.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-1fdfe995d145d18242bd5bae58e952eeL3) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Company Email Password | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL2) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Company Email Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/rekuest.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-2d1eb628901c9021c6ea719386881935L11) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Company Email Password | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/fluss.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-beb528fb07c3513b6d4a19eeb58f54bfL11) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Django Secret Key | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/port.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-7ba4e7a196b0ecf33177bba737a4666cL16) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Private Key | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL615) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Private Key | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL278) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Private Key | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL448) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Private Key | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL135) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL432) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Django Secret Key | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/fluss.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-beb528fb07c3513b6d4a19eeb58f54bfL16) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | f7c95caad7efbca15824261c911df7775646ec15 | website/validated.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-ab895faca3355565277632c3fe9e6b0bL413) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Django Secret Key | f7c95caad7efbca15824261c911df7775646ec15 | website/configs/rekuest.yaml | [View secret](https://github.com/jhnnsrs/arkitekt/commit/f7c95caad7efbca15824261c911df7775646ec15#diff-2d1eb628901c9021c6ea719386881935L16) | | [8939825](https://dashboard.gitguardian.com/incidents/8939825?occurrence=120801769) | Generic High Entropy Secret | 88394e39ad5e54a9b2c236dcb6b95f7c9ce90893 | examples/com.example.random_shapes-latest_cache.json | [View secret](https://github.com/jhnnsrs/arkitekt/commit/88394e39ad5e54a9b2c236dcb6b95f7c9ce90893#diff-9275738408ce30a003570f063d9243d5536cd771a87c50fdec98d2b94330856fL1) | | [8939826](https://dashboard.gitguardian.com/incidents/8939826?occurrence=120801768) | Generic High Entropy Secret | 88394e39ad5e54a9b2c236dcb6b95f7c9ce90893 | examples/integration/elab_integration.py | [View secret](https://github.com/jhnnsrs/arkitekt/commit/88394e39ad5e54a9b2c236dcb6b95f7c9ce90893#diff-e3469d3c1be8b74f494d8efa91167665c5e52f7a1b3e2d34443a731aebfef14fL9) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1068 lines in your changes are missing coverage. Please review.

Comparison is base (285f455) 68.77% compared to head (287d2c4) 53.64%. Report is 79 commits behind head on master.

:exclamation: Current head 287d2c4 differs from pull request most recent head 72cd060. Consider uploading reports for the commit 72cd060 to get more accurate results

Files Patch % Lines
arkitekt/qt/magic_bar.py 24.54% 209 Missing :warning:
arkitekt/cli/commands/run/dev.py 25.78% 118 Missing :warning:
arkitekt/builders.py 24.07% 82 Missing :warning:
arkitekt/cli/commands/port/wizard.py 33.03% 75 Missing :warning:
arkitekt/cli/commands/manifest/version.py 41.33% 44 Missing :warning:
arkitekt/cli/commands/gen/init.py 24.52% 40 Missing :warning:
arkitekt/cli/io.py 40.29% 40 Missing :warning:
arkitekt/apps/qt.py 13.95% 37 Missing :warning:
arkitekt/cli/commands/port/publish.py 42.59% 31 Missing :warning:
arkitekt/apps/types.py 70.58% 30 Missing :warning:
... and 35 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8 +/- ## =========================================== - Coverage 68.77% 53.64% -15.14% =========================================== Files 109 61 -48 Lines 2937 2304 -633 =========================================== - Hits 2020 1236 -784 - Misses 917 1068 +151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.