search

arkivanov / Minesweeper

Minesweeper game implemented in Kotlin and Compose Multiplatform
https://arkivanov.github.io/Minesweeper/
Apache License 2.0
75 stars 2 forks source link

Refactoring #12

Closed b0r1ngx closed 7 months ago

b0r1ngx commented 7 months ago

Very like your code-style and how you defining an architecture in the app.

But want to add this refactoring things to project, because I'm thinks that too much symbols in one line of code is not so good: 1) Eyes not need always run to right side of an file (to the right half of a line, more than ~70 symbols) 2) Also if you want to check code from mobile device, it's inconvenient to always swipe right and left

arkivanov commented 7 months ago

Thanks for the PR, but I prefer to always wrap lines after = in functions. And also in properties unless it's a one-liner. I also prefer single line calls when I find it not too complicated. I know, it's subjective. Sorry, but I won't accept PRs for code style changes.

b0r1ngx commented 7 months ago

Thanks for the PR, but I prefer to always wrap lines after = in functions. And also in properties unless it's a one-liner. I also prefer single line calls when I find it not too complicated. I know, it's subjective. Sorry, but I won't accept PRs for code style changes.

Sure, my opinion is also subjective, thanks!