search

arkivanov / Minesweeper

Minesweeper game implemented in Kotlin and Compose Multiplatform
https://arkivanov.github.io/Minesweeper/
Apache License 2.0
74 stars 2 forks source link

Extract strings in code to resources/values/strings.xml and used it from there #21

Closed b0r1ngx closed 6 months ago

b0r1ngx commented 6 months ago

Hello, Arkadii, I'm done with extracting user strings from code, please review.

I think that we may extract strings only that user interact with, because later its valueble for translate it for example.

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The recent updates across the Minesweeper app's codebase primarily focus on enhancing internationalisation and localisation support. This includes adding imports for generated resources, utilising resource strings for UI text like actions, labels, and buttons, and incorporating ExperimentalResourceApi for advanced resource handling. Additionally, there's a specific note on exploring resource usage for WebAssembly, indicating a forward-looking approach to cross-platform compatibility.

Changes

Files Changes
.../game/GameContent.kt
.../root/RootContent.kt
.../settings/EditSettingsContent.kt		 Added imports for generated resources and utilised resource strings for UI elements like actions, labels, and buttons.
.../jvmMain/kotlin/Main.kt Added resource handling for window title.
.../wasmJsMain/kotlin/Main.kt Added a TODO for exploring resource usage in WebAssembly.

🐰✨
In a land of code and binary,
Where resources were once a mystery,
Came a rabbit, wise and merry,
To sprinkle localisation, quite the fairy.
With strings and resources, all in a flurry,
Our app now speaks globally, no need to worry!
🌍✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
b0r1ngx commented 6 months ago

One more thing that I want to say, the task of increasing level of accessibility is a not easy task and requires additional work and tests, so I think in context of this PR we may not target on this, but awesome that we have discussion about it!

b0r1ngx commented 6 months ago

Is GIVEN_created_WHEN_first_click_on_cell_THEN_state_started test start failing? (check auto build)

arkivanov commented 6 months ago

Is GIVEN_created_WHEN_first_click_on_cell_THEN_state_started test start failing? (check auto build)

I think test test is flaky, filed #22.