search

arkivverket / noark5-tjenestegrensesnitt-standard

6 stars 11 forks source link

Issues with OData contains filter example in chapter 6 #293

Closed ivaylomitrev closed 1 year ago

ivaylomitrev commented 1 year ago 
       Prosjekt  NOARK 5 Tjenestegresesnitt
       Kategori  Noark 5.5.0 TG versjon 1.0
    Alvorlighet  kommentar / protest
   Meldingstype  utelatt / trenger klargjøring
Brukerreferanse  user@example.com
    Dokumentdel  #6

Beskrivelse

There are several issues with the OData v4 contains filter example in chapter 6.

Namely:

../arkivdel/1235/mappe?$top=2&$filter=contains(‘testmappe’, tittel) eq true $orderby=endretDato desc

Ønsket endring

The same needs to be changed to:

../arkivdel/1235/mappe?$top=2&$filter=contains(tittel, ‘testmappe’)&$orderby=endretDato desc

The arguments of contains were switched, eq true is obsolete (and am not sure if even supported), and there is a missing & before $orderby.

ivaylomitrev commented 1 year ago

I have opened a PR here: https://github.com/arkivverket/noark5-tjenestegrensesnitt-standard/pull/292

tsodring commented 1 year ago

Thanks. These are an obvious typo so I am surprised they haven't been caught before. #292 is good to go!

ivaylomitrev commented 1 year ago

Great! Thanks! I (for natural reasons) don't have permissions to merge though so this PR (and another of mine) are at your discretion for when/if you decide to merge them.

petterreinholdtsen commented 1 year ago

PR #292 is now merged.