search

arkmanager / ark-server-tools

Set of server tools used to manage ARK: Survival Evolved servers on Linux
MIT License
680 stars 144 forks source link

Shellcheck #1139

Closed Alphakilo closed 2 years ago

Alphakilo commented 4 years ago

In an effort to make the arkmanager more robust, I've let it lint by shellcheck, got rid of all "errors" and implemented some of their hints in different warnings.

On top of that, I've set up a Github action that runs shellcheck on every push. It'll be nagging a lot, since I've configured the "error" threshold as "warning" (see f5312ee), but I'll go ahead and change more things.

klightspeed commented 4 years ago

I like it.

Alphakilo commented 4 years ago

On another note: can I persuade netinst.sh or the updater to the branch on my fork, so I can run some tests?

I've noticed the variables are there, but I have not figured out how to parameterize those.

klightspeed commented 4 years ago

I have added a --repo=* parameter to netinstall.sh, so you can specify --repo=Alphakilo/ark-server-tools

klightspeed commented 2 years ago

I have now implemented the idea in this pull request.