search

arknoll / ansible-role-selenium

Ansible Role Selenium
https://galaxy.ansible.com/list#/roles/4340
Other
20 stars 52 forks source link

Use boolean type for selenium_install_firefox. #4

Closed thom8 closed 8 years ago

thom8 commented 8 years ago

Firefox is no longer installing by default, this PR makes the selenium_install_firefox var a boolean which fixes this.

Ansible recommends using yes/no for booleans, however true/false also works.

thom8 commented 8 years ago

This is not working because selenium_install_firefox is not equal to the string 'true'

kevinquillen commented 8 years ago

After making the proposed changes here, I can confirm that Firefox installed successfully which resolved errors in Selenium about missing binaries in PATH.

tom-ashe commented 8 years ago

I can also confirm this resolves this issue for us. It would be great to get it committed.

thom8 commented 8 years ago

Seems like this role is no longer maintained we have created a fork and added this PR -- https://galaxy.ansible.com/beetboxvm/selenium/

oxyc commented 8 years ago

@arknoll any plans for further development of this project? Currently Drupal VM uses this role but if you consider it an abandoned project we should probably look for another solution.

geerlingguy commented 8 years ago

Note that I've also left @arknoll a note offline—hopefully we can get this merged and a new tagged release on Galaxy, at the least (to stop the bleeding). I'm open to switching to someone else's Selenium/related roles... the main goal for me is: support for all the supported CentOS/Ubuntu versions, stability, and some sort of maintenance plan :)

arknoll commented 8 years ago

Thank you @geerlingguy for pinging me outside of github. For some reason I was not seeing the notifications from this repository. I merged, tagged, and deployed up to ansible galaxy 1.2.0.