arknoll / ansible-role-selenium

Ansible Role Selenium
https://galaxy.ansible.com/list#/roles/4340
Other
20 stars 52 forks source link

systemd unit on CentOS 7 fails to start #45

Open jtognazzi opened 6 years ago

jtognazzi commented 6 years ago

Because of 4f88a66c31cb6f3374d6c95a1a153463fe16a72a the selenium systemd unit is failing to start. The problem seems to be with the quoting of the xvfb-run arguments.

Besides the integration tests failed to notice the failure because the systemd start command doesn't return any error.

Looking at the forks of this project, I found that @MassiveHiggsField has fixed these in his project https://github.com/MassiveHiggsField/ansible-role-selenium

@MassiveHiggsField do you plan to do a pull request ?

MassiveHiggsField commented 6 years ago

Already done https://github.com/arknoll/ansible-role-selenium/pull/44

rmeleromira commented 6 years ago

This can also be fixed by escaping the spaces for the exec arguments selenium_xvfb_args: "--server-args='-screen\\ 0,\\ 1920x1080x24'"