search

arkokoley / pdfvuer

A PDF viewer for Vue using Mozilla's PDF.js that supports both Vue2 and Vue3
https://arkokoley.github.io/pdfvuer
MIT License
918 stars 131 forks source link

updated PDFPageView.update calls to supply an object instead of positional args #146

Closed ewchow closed 1 year ago

ewchow commented 1 year ago

pdfjs-dist v2.14.305 has a different call signature for the PdfPageView.update function. It used to accept positional arguments in earlier versions, but it now accepts an object.

Fixes issue #134

Describe the changes you have made in this PR -

Updated the calls to PDFPageView.update to supply an object instead of positional arguments.

Have you updated the readme?

It wasn't necessary.

Screenshots of the changes (If any) -

paulfayai commented 1 year ago

Nice one @ewchow. This is blocking updating to v1.10.0 which has some nice pdf.js improvements so it would great to get this merged @arkokoley 🙏

arkokoley commented 1 year ago

@ewchow Thanks for this change. Merging this and closing #134!

paulfayai commented 1 year ago

@arkokoley the quick response is much appreciated! Does this need a version bump / NPM release? v1.10.0 is still broken via NPM.

fszqj commented 6 months ago

@arkokoley Just the same as above，When will this be released to npm?