Fixed support for symbols ID which are not numbers

arkon / ng-inline-svg

[Inactive] Angular directive for inserting an SVG file inline within an element.

https://echeung.me/ng-inline-svg/

MIT License

210 stars 88 forks source link

Fixed support for symbols ID which are not numbers #98

Closed Xample closed 5 years ago

Xample commented 5 years ago

Implemented the solution on: https://stackoverflow.com/a/20306218/532695

arkon commented 5 years ago

I assume the PR title is actually negated, but thanks for the PR!

Xample commented 5 years ago

@arkon you are right, I started forking the repository and changed the few lines in the code directly on master. Good practice would have been to download on my computer, create 2 separate branches and make a separate pull request for each of them.