Issue 148 sidebardoesnotremoveclicklistenerifchangedduringsidebarisopen

arkon / ng-sidebar

[Inactive] Angular sidebar component.

https://echeung.me/ng-sidebar

MIT License

388 stars 136 forks source link

Issue 148 sidebardoesnotremoveclicklistenerifchangedduringsidebarisopen #149

Closed cluetjen closed 6 years ago

cluetjen commented 6 years ago

Checks the value of closeOnClickOutside and keyClose in ngOnChanges an removes listeners if value is false. I tested closeOnClickOutside but please do some testing with keyDown. I'm not using it and had troubles getting the demo project to run (I'm using ng cli, not webpack directly).

cluetjen commented 6 years ago

@arkon - could you already take a look on this pr or do you need more info / anything I can do?

arkon commented 6 years ago

Sorry for the delay. Published as v7.2.1.