SBC: Require sbc >= 1.5.

paul-1 commented 1 year ago

function sbc_reinit_a2dp was not exposed in the shared library until v1.5

See #639

Use of sbc_reinit_a2dp was added in commit 44a5dd9a17eaf3b2a92ea2d1859b64f9837f2b4a

borine commented 1 year ago

Please can you also mention the version requirement in INSTALL.md (line 32) ? Thanks

paul-1 commented 1 year ago

I was going to, but noticed only bluez had a version called out there. Should we add versions to all libraries in Install.md?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (ee6e677) 70.80% compared to head (1fa7eca) 70.75%.

:exclamation: Current head 1fa7eca differs from pull request most recent head 23662ac. Consider uploading reports for the commit 23662ac to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #645 +/- ## ========================================== - Coverage 70.80% 70.75% -0.06% ========================================== Files 48 48 Lines 8999 8999 ========================================== - Hits 6372 6367 -5 - Misses 2627 2632 +5 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/Arkq/bluez-alsa/pull/645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arkadiusz+Bokowy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

arkq commented 1 year ago

Many thanks for the patch!

arkq / bluez-alsa

SBC: Require sbc >= 1.5. #645

Codecov Report