search

arkq / bluez-alsa

Bluetooth Audio ALSA Backend
MIT License
864 stars 189 forks source link

Alsa plugin resilience #669

Closed borine closed 11 months ago

borine commented 1 year ago

Some more tweaks to the PCM plugin to help isolate it from failures in the server. Also includes a fix for a D-Bus test failure (but it seems there is still at least one other bug in there that causes occasional failures in github actions).

codecov[bot] commented 1 year ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ed4def8) 71.70% compared to head (aaaac21) 71.66%.

Files Patch % Lines
src/shared/dbus-client.c 37.50% 5 Missing :warning:
src/asound/bluealsa-pcm.c 20.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #669 +/- ## ========================================== - Coverage 71.70% 71.66% -0.05% ========================================== Files 49 49 Lines 9254 9260 +6 ========================================== Hits 6636 6636 - Misses 2618 2624 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arkq commented 1 year ago

Also includes a fix for a D-Bus test failure (but it seems there is still at least one other bug in there that causes occasional failures in github actions).

It fails because g_test_dbus_down(conn->dbus) hangs... and to be honest I do not know why. It seems that the problem is in the g_test_dbus itself (based on issues found on the Internet).