codecov[bot]
commented
11 months ago Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.
Comparison is base (
b65a40f) 71.68% compared to head (6d90f7b) 71.67%.
| Files | Patch % | Lines |
|---|---|---|
| src/asound/bluealsa-pcm.c | 79.41% | 7 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #674 +/- ## ========================================== - Coverage 71.68% 71.67% -0.02% ========================================== Files 49 49 Lines 9286 9254 -32 ========================================== - Hits 6657 6633 -24 + Misses 2629 2621 -8 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Recent testing with alsa-lib 1.2.9 and 1.2.10 has shown that the "short write" issue described in PR #567 still exists with current alsa-lib releases. This PR modifies the way that the bluealsa pcm plugin handles a buffer that is not a whole multiple of the period size, such that the short write failure is avoided without needing the previous ugly workaround of forcibly resizing the buffer.
alsalib releases 1.1.4 to 1.2.5.1 still have a different bug so that the buffer size hack is still needed for those versions.