search

arkq / bluez-alsa

Bluetooth Audio ALSA Backend
MIT License
864 stars 189 forks source link

Command line option --loglevel #680

Closed borine closed 9 months ago

borine commented 9 months ago

've been playing around with HFP recently, and discovered that my journal log was being spammed with thousands of bluealsa: W: Missing mSBC packets messages. This is not good for an embedded system with limited log space, so I thought it would be good to be able to filter out info and warning messages. This PR is my attempt to achieve that.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b6b4412) 71.10% compared to head (3309200) 71.14%. Report is 3 commits behind head on master.

Files Patch % Lines
utils/aplay/aplay.c 66.66% 2 Missing :warning:
src/shared/log.c 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #680 +/- ## ========================================== + Coverage 71.10% 71.14% +0.03% ========================================== Files 55 55 Lines 10140 10150 +10 ========================================== + Hits 7210 7221 +11 + Misses 2930 2929 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arkq commented 9 months ago

I've added support for bashcompletion and made small cleanup (after some consideration I don't think that reporting error from the log_set_min_priority() is required at all... so I've removed the check in that function, I hope that you don't mind).

Once again, many thanks for the patch!

EDIT: Also, something strange has happened with the PR.... merged, but all the changes has disappeared from the "Files changed" tab.... o_O