arkrow / PyMusicLooper

A python program for repeating music endlessly and creating seamless music loops, with play/export/tagging support.
https://pypi.org/project/pymusiclooper/
MIT License
259 stars 24 forks source link

__version__ Not Updated #25

Closed MattEqualsCoder closed 11 months ago

MattEqualsCoder commented 11 months ago

Before continuing with the bug report, does updating to the latest version fix this issue? [Yes/No] - No

Describe the bug init.py still has version 3.1.0 in it, so the --version flag seems to be returning 3.1.0 even on 3.2.0: https://github.com/arkrow/PyMusicLooper/blob/master/pymusiclooper/__init__.py

image

Debugging Information I can confirm I've updated because the new --alt-export-top feature seems to be working:

$ pymusiclooper export-points --min-duration-multiplier 0.25 --path 11Green\ Brinstar.mp3 

Loop points for "11Green Brinstar.mp3":
LOOP_START: 3561463
LOOP_END: 5942845

$ pymusiclooper export-points --min-duration-multiplier 0.25 --path 11Green\ Brinstar.mp3 --alt-export-top 5
3561463 5942845 0.20004414021968842 0.24657928792024109 0.9886344750947615
3517575 6163578 0.14694753289222717 0.0888093500287539 0.988366104061565
3252703 8191956 0.1389075517654419 0.1795756363760006 0.9883327886663374
3103721 6014458 0.2082384079694748 0.13788309020281986 0.9882790035343043
3252703 5898752 0.18834000825881958 0.05296680661302844 0.988147926132887

$ pymusiclooper --version
pymusiclooper 3.1.0

Expected behavior 3.2.1 should be returned

Environment Information (please complete the following information):

Additional context Add any other context about the problem here.

arkrow commented 11 months ago

Oops, looks like I forgot about the __version__ constant; I got used to old packaging system reading it from one place. Thanks for catching this and reporting it!

Now fixed in version 3.2.2 and shouldn't occur in the future, since it now reads the installed package's version directly using importlib.metadata.