Enforce trait bounds for `CRHScheme::Parameters` and `TwoToOneCRHScheme::Parameters`

mmagician commented 1 year ago

Description

closes: #113

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[x] Targeted PR against correct branch (main)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[x] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

Pratyush commented 1 year ago

Should we add these trait bounds also to CRH::Output?

mmagician commented 1 year ago

It's already on Output: https://github.com/arkworks-rs/crypto-primitives/blob/c3af79daf85a8582f642c2a6e0db45207839452e/src/crh/mod.rs#L23-L31

arkworks-rs / crypto-primitives

Enforce trait bounds for `CRHScheme::Parameters` and `TwoToOneCRHScheme::Parameters` #114

Description