arkworks-rs / crypto-primitives

Interfaces and implementations of cryptographic primitives, along with R1CS constraints for them
https://www.arkworks.rs
Apache License 2.0
165 stars 79 forks source link

Correctly absorb curve points into cryptographic sponge #115

Closed slumber closed 1 year ago

slumber commented 1 year ago

Description

Tests prove that they don't match. 0-case for SW curve won't pass still because it requires changes to r1cs-std.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

Pratyush commented 1 year ago

Now that the PR to r1cs-std is merged, how should this proceed?

slumber commented 1 year ago

Now that the PR to r1cs-std is merged, how should this proceed?

Should I add [patch.crates-io]?

Pratyush commented 1 year ago

Yes let's patch

slumber commented 1 year ago

@Pratyush is it good to merge?