Previously, the Bowe-Hopwood CRH gadget would silently fail to hash inputs whose bitlength exceeded NUM_WINDOWS * WINDOW_SIZE * 3. This makes it easy to miss simple things in development, but it's probably not a security issue, since any gadget eval is almost certainly accompanied by a native eval, which does have the size check. Instead, it should say that the input is too large, as the Pedersen CRH gadget does.
This PR adds the check, and also a regression test.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[X] Targeted PR against correct branch (main)
[X] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[X] Wrote unit tests
[X] Updated relevant documentation in the code
[X] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[X] Re-reviewed Files changed in the Github PR explorer
Description
Previously, the Bowe-Hopwood CRH gadget would silently fail to hash inputs whose bitlength exceeded
NUM_WINDOWS * WINDOW_SIZE * 3. This makes it easy to miss simple things in development, but it's probably not a security issue, since any gadget eval is almost certainly accompanied by a native eval, which does have the size check. Instead, it should say that the input is too large, as the Pedersen CRH gadget does.This PR adds the check, and also a regression test.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer