With the current implementation of Poseidon, when trying to absorb a field element from a different field of sponge, there is no error and the developer would think everything is right :) The unwrap helps with making panics.
Also, I changed the repos from curves to algebra.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[ ] Targeted PR against correct branch (main)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
With the current implementation of Poseidon, when trying to absorb a field element from a different field of sponge, there is no error and the developer would think everything is right :) The
unwrap
helps with making panics.Also, I changed the repos from
curves
toalgebra
.Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer