Fix CI and build for each feature

autquis commented 6 months ago

Before this fix and after #141, if you run

cargo build --no-default-features --features merkle_tree

you will get some errors. With this PR, we fix the imports for Vec in case of no-std.

Also, we changed CI to have different features so that we catch this kind of issue later.

depends on: #141

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against correct branch (main)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

autquis commented 6 months ago

Also, once the changes are approved and before the merge, I would like to do some cleanup for the imports of the repo.

autquis commented 6 months ago

Well, it seems now that I have to open another PR for cleaning up the imports. :D

mmagician commented 6 months ago

Hmm really, I thought this one was also doing that. Shall we reopen the other PR I closed, would that help?

autquis commented 6 months ago

I can do it on the closed PR, but it's same as opening a new one. Which one should I proceed with?

mmagician commented 6 months ago

Ah no nvm, I thought your import fixed were either here or on the other closed PR. Then new one pls

arkworks-rs / crypto-primitives

Fix CI and build for each feature #142