This is an implementation of gadgets for SHA-384 and SHA-512 based on the implementation of the SHA-256 gadget.
The commits are based on the release-0.4 branch which is not yet merged into main.
There is some code duplication between the different SHA modules. This can likely be resolved with a bit of restructuring or by using macros to generate certain parts of the code.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[x] Targeted PR against correct branch (main)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[x] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
Description
This is an implementation of gadgets for SHA-384 and SHA-512 based on the implementation of the SHA-256 gadget. The commits are based on the release-0.4 branch which is not yet merged into main.
The code relies on the fix for add_many proposed in the following pull request: https://github.com/arkworks-rs/r1cs-std/pull/113.
There is some code duplication between the different SHA modules. This can likely be resolved with a bit of restructuring or by using macros to generate certain parts of the code.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer